flow icon indicating copy to clipboard operation
flow copied to clipboard

Run TaskGenerateHilla only in build-frontend phase after npm dependencies install

Open platosha opened this issue 1 year ago • 1 comments

Description of the bug / feature

TaskGenerateHilla runs the multi-module parser / generator for Hilla, which depend on:

  • Java compiled classes
  • npm dependencies, namely @hilla/generator-typescript-cli

Minimal reproducible example

  • Create a project with 23.2-SNAPSHOT Hilla and Flow
  • Include / enable the multi-module engine
  • Start the application

Expected behavior

The engine is run by the build-frontend goal or DevModeInitializer, after npm dependencies are installed.

Actual behavior

The prepare-frontend goal attempts to run TaskGenerateHilla, which fails because of missing npm dependencies.

Versions:

- Vaadin / Flow version: 23.2-SNAPSHOT

platosha avatar Aug 05 '22 14:08 platosha

The build-frontend task is not run in dev mode. Wouldn't it be easier to fix the order of execution in prepare-frontend?

cromoteca avatar Aug 07 '22 09:08 cromoteca

This ticket/PR has been released with Vaadin 23.2.0.beta2 and is also targeting the upcoming stable 23.2.0 version.

vaadin-bot avatar Aug 18 '22 08:08 vaadin-bot