flow-components icon indicating copy to clipboard operation
flow-components copied to clipboard

refactor: remove custom I18N merging logic

Open sissbruecker opened this issue 5 months ago • 4 comments

Description

Removes custom logic for merging I18N values from Flow components with web components defaults. That should now be covered by all web components having support for setting partial I18N objects.

Type of change

  • Refactoring

sissbruecker avatar Sep 08 '25 10:09 sissbruecker

Should this also change similar logic in AppLayout and MultiSelectComboBox?

ugur-vaadin avatar Sep 09 '25 16:09 ugur-vaadin

Should this also change similar logic in AppLayout and MultiSelectComboBox?

Thanks, I missed those. Turns out the partial I18n mechanism was missing for MSCB, so I created a PR for this first: https://github.com/vaadin/web-components/pull/10147

The tests for those components will also need to be changed as they make assertions on the i18n property. I'll have to think about whether ITs are still feasible or if they should be more basic unit tests instead.

sissbruecker avatar Sep 09 '25 18:09 sissbruecker

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 28 '25 13:10 CLAassistant