flow-components
flow-components copied to clipboard
Added HasLabelAsText interface to ButtonElement
Description
Elements having their labels in their text (such as buttons) must implement a new, method-less interface HasLabelAsText in their element tester (such as NativeButtonElement for the NativeButton component and ButtonElement for the Button component) in order for the withCaption[Containing] selectors to work for them.
This is a related Flow Components change for https://github.com/vaadin/testbench/issues/1183
Type of change
- [ ] Bugfix
- [x] Feature
Checklist
- [x] I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
- [x] I have added a description following the guideline.
- [x] The issue is created in the corresponding repository and I have referenced it.
- [x] I have added tests to ensure my change is effective and works as intended.
- [x] New and existing tests are passing locally with my change.
- [x] I have performed self-review and corrected misspellings.
- [ ] I have not completed some of the steps above and my pull request can be closed immediately.
Additional for Feature type of change
- [x] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.
The tests look good. However, I would not mix the jetty upgrade in this PR.
Removed.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.