flow-components icon indicating copy to clipboard operation
flow-components copied to clipboard

Added HasLabelAsText interface to ButtonElement

Open joelpop opened this issue 1 year ago • 2 comments

Description

Elements having their labels in their text (such as buttons) must implement a new, method-less interface HasLabelAsText in their element tester (such as NativeButtonElement for the NativeButton component and ButtonElement for the Button component) in order for the withCaption[Containing] selectors to work for them.

This is a related Flow Components change for https://github.com/vaadin/testbench/issues/1183

Type of change

  • [ ] Bugfix
  • [x] Feature

Checklist

  • [x] I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • [x] I have added a description following the guideline.
  • [x] The issue is created in the corresponding repository and I have referenced it.
  • [x] I have added tests to ensure my change is effective and works as intended.
  • [x] New and existing tests are passing locally with my change.
  • [x] I have performed self-review and corrected misspellings.
  • [ ] I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • [x] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

joelpop avatar May 06 '24 16:05 joelpop

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 06 '24 16:05 CLAassistant

The tests look good. However, I would not mix the jetty upgrade in this PR.

Removed.

joelpop avatar May 08 '24 23:05 joelpop

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

vaadin-bot avatar May 31 '24 11:05 vaadin-bot