flow-components fix: make form layout responsive steps getter work properly

fix: make form layout responsive steps getter work properly

Open akhodyko opened this issue 1 year ago • 5 comments

Description

Form layout responsive steps getter does not work at all. Included test describes the case.

Type of change

[x] Bugfix
[ ] Feature

Apr 26 '24 14:04 akhodyko

All committers have signed the CLA.

Apr 26 '24 14:04 CLAassistant

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Apr 26 '24 14:04 CLAassistant

Dear @akhodyko, the API has been confirmed to not be working properly and it should be fixed. Could you please share your use case for the API usage, so enhancements can be considered along the way and corresponding issues can be created?

Apr 30 '24 07:04 yuriy-fix

Dear @akhodyko, the API has been confirmed to not be working properly and it should be fixed. Could you please share your use case for the API usage, so enhancements can be considered along the way and corresponding issues can be created?

My use case is quite simple, it just about adding an additional responsiveStep to existing:

FormLayout formLayout = getFormLayout();
FormLayout.ResponsiveStep responsiveStep = createResponsiveStep();
List<FormLayout.ResponsiveStep> responsiveSteps = new ArrayList<>(formLayout.getResponsiveSteps());
responsiveSteps.add(responsiveStep);
formLayout.setResponsiveSteps(responsiveSteps);

May 02 '24 08:05 akhodyko

We had an internal discussion and decided to reuse the existing public constructor instead of introducing a new private one. We can always add the default constructor later if there is a request for it. I've updated the PR accordingly.