flow-components icon indicating copy to clipboard operation
flow-components copied to clipboard

Spreadsheet table filter popups still displayed in the UI even if setVisible(false) and setHeaderHidden(true) are called

Open WoozyG opened this issue 1 year ago • 1 comments

Description

there is no way to hide/remove the Spreadsheet component overlays for table column filter menus.

As the title says, even if setVisible(false) and setHeaderHidden(true) are called in an overridden registerTable() method, the UI still renders the overlays.

There is no way to remove the overlays entirely, and we can't inject a subclass of SpreadsheetFilterTable or replace with SpreadsheetTable without possibly creating side effects, as there is no preventing the caller from doing further work with the instance they passed, even if the implementation ignores it.

Expected outcome

If the overlay has no content, it shouldn't be displayed at all.

Ideally, this would not be needed if #5607 were fixed.

Minimal reproducible example

https://github.com/WoozyG/sheet-tables

Steps to reproduce

Run the given sample project, and note the tables still have overlay buttons even though they have no content.

Environment

Vaadin version(s): 24.2 OS: N/A

Browsers

Issue is not browser related

WoozyG avatar Oct 19 '23 23:10 WoozyG