docs icon indicating copy to clipboard operation
docs copied to clipboard

Third party icons generation is broken

Open mindej opened this issue 1 year ago • 2 comments

When generating a new icon set from the SVG file icons is broken.

To reproduce:

  1. Download SVG from: https://www.svgrepo.com/svg/171799/pdf-file-format-symbol
  2. Generate icon set from documentation https://vaadin.com/docs/latest/components/icons

I expected that icon should be loaded into the page but right now Vaadin shows a blank icon.

SVG data is there but it is broken: image

mindej avatar Aug 08 '23 14:08 mindej

Thanks for reporting! The generator is perhaps a bit too naive how it handles the files you upload (simply copies the whole file string content to a new SVG element definition).

I recall testing it with FontAwesome SVG files, and those worked as expected. Perhaps by comparing them to this SVG file gives a hint why it doesn't work.

jouni avatar Aug 09 '23 19:08 jouni

@jouni Here is 1 more good source of SVGs https://github.com/hampusborgos/country-flags/tree/main/svg

I have tried to generate icons but some flags do not work for me.

mindej avatar Aug 23 '23 12:08 mindej