charts icon indicating copy to clipboard operation
charts copied to clipboard

Highcharts module offline-exporting.js is not included

Open WoozyG opened this issue 6 years ago • 2 comments

This isn't loaded as part of HighchartsScriptLoader, but should be, or at least should be an option. Until it is, how should I go about getting the proper version loaded, preferably in a way that doesn't break when the Highcharts version is bumped?

WoozyG avatar Apr 24 '18 19:04 WoozyG

Thanks for the report. Adding to 4.1. In the meantime, maybe @alvarezguille can give you some way to load it.

johannesh2 avatar Apr 25 '18 06:04 johannesh2

I did a small example of how to add one Highcharts extension some time ago, you can check it in https://github.com/alvarezguille/charts-export-csv Main steps are explained in readme Regarding the version compatibility, I did a smoke test and the module for Highcharts 4.2.6 seems to work even with Highcharts latest version https://jsfiddle.net/alvarezg/vLjb5fa0/. Anyway once it's included in Vaadin Charts and released you should probably remove the resource loading from your project. If you want to play safe you can check that the module is not there before loading, something similar to this snippet https://github.com/vaadin/charts/blob/master/addon/src/main/java/com/vaadin/addon/charts/client/HighchartsScriptLoader.java#L84-L89 but checking for Highcharts.CanVGRenderer

alvarezguille avatar Apr 25 '18 06:04 alvarezguille