vLKp

Results 231 comments of vLKp

[Initialize obsolete fields](/dxx-rebirth/dxx-rebirth/commit/fe04c3fef642e2d6cd597026789efd1651fd5b45) fixes some of these warnings, but many remain. Many objects seem not to initialize part of `ctype` before writing.

[Avoid uninitialized use of object::ctype.ai_info.danger_laser_signature](/dxx-rebirth/dxx-rebirth/commit/949d56fdd9b3349e77cd95d657da6889014e2ba3) fixes another warning in this area.

Nothing reported here justifies blocking the release. Writing uninitialized memory is bad form, but Rebirth does not store secrets that could leak to the disk, nor are any leaked fields...

This sounds plausible, but I am wary of using polymorphism for this. Compilers implement it correctly, but it has a runtime cost (particularly with regard to branch prediction), so I...

I think the performance hit would be minimal in areas where the code already uses function pointers. Virtual function calls typically require one extra dereference, which should be quite cheap...

As part of this work, it would be nice to eliminate `window_exists`. I have always been uncomfortable with it, since it is designed to be passed a pointer to a...

I do not understand the concern in the linked stackoverflow post. Incrementing iterators is cheap. The latter issue, regarding derived types, is a valid concern. `std::list` stores the managed type...

I am uncomfortable with the idea that `timer_delay2` can cause the game window to be destroyed, and in particular that anyone who calls it must handle that case. I recognize...

I have no objection if you want to patch newmenu to handle this better.

For the purpose of avoiding an installation, it does not seem like it is worth it. However, I think it would be nice if passing `-nosound` completely bypassed all sound...