otis-web icon indicating copy to clipboard operation
otis-web copied to clipboard

Auto accept previous year units

Open Incompleteusern opened this issue 2 years ago • 5 comments

Fixes #300 #318.

Automatically accepts petitions of a user that has students of another instance with that unit unlocked.

Incompleteusern avatar Oct 26 '23 03:10 Incompleteusern

Some changes requested:

  1. There's some random print statements that need to be fixed
  2. I think this is an O(n) query where n is the number of times you've done OTIS, but it really should be O(1). Django should support something like Student.objects.filter(user=student.user, curriculum__<something>=unit), I don't know off my head but I'd be shocked if it didn't exist.
  3. Needs unit tests.

vEnhance avatar Oct 27 '23 03:10 vEnhance

thanks, can we actually just delete the stale lines rather than comment them out

vEnhance avatar Oct 27 '23 12:10 vEnhance

still waiting on unit tests here

vEnhance avatar Dec 19 '23 18:12 vEnhance

is this dead

jatloe avatar Apr 08 '24 23:04 jatloe

I don't feel like working on this right now. I might finish unit tests when this OTIS semester is over.

Incompleteusern avatar Apr 09 '24 03:04 Incompleteusern

Pull Request Test Coverage Report for Build 10127134543

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.779%

Totals Coverage Status
Change from base Build 10125073972: 0.02%
Covered Lines: 6757
Relevant Lines: 7210

💛 - Coveralls

coveralls avatar Jul 27 '24 22:07 coveralls

Unit Tests should be done.

Incompleteusern avatar Jul 27 '24 23:07 Incompleteusern

Wonderful timing for the new year...

chessisdabest avatar Aug 01 '24 14:08 chessisdabest