otis-web
otis-web copied to clipboard
Auto accept previous year units
Fixes #300 #318.
Automatically accepts petitions of a user that has students of another instance with that unit unlocked.
Some changes requested:
- There's some random print statements that need to be fixed
- I think this is an O(n) query where n is the number of times you've done OTIS, but it really should be O(1). Django should support something like
Student.objects.filter(user=student.user, curriculum__<something>=unit), I don't know off my head but I'd be shocked if it didn't exist. - Needs unit tests.
thanks, can we actually just delete the stale lines rather than comment them out
still waiting on unit tests here
is this dead
I don't feel like working on this right now. I might finish unit tests when this OTIS semester is over.
Pull Request Test Coverage Report for Build 10127134543
Details
- 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.02%) to 91.779%
| Totals | |
|---|---|
| Change from base Build 10125073972: | 0.02% |
| Covered Lines: | 6757 |
| Relevant Lines: | 7210 |
💛 - Coveralls
Unit Tests should be done.
Wonderful timing for the new year...