otis-web icon indicating copy to clipboard operation
otis-web copied to clipboard

Published 20 hours ago • verified publisher icon vEnhance

Update Tables

Open AmoleR opened this issue 4 years ago • 20 comments
trafficstars

In wikihaxx/mdx/otis.py, change the table from a lazy float: right to an actual alignment, such as below from Wikipedia.

Wikipedia Demonstration of Proper Alignment

AmoleR avatar Aug 25 '21 06:08 AmoleR

What does it mean to "actual alignment"?

theMetaHack avatar Dec 19 '21 20:12 theMetaHack

Well a float right just means try to slap it to the right, good luck if it fails. A better solution would be how Wikipedia does it (I forgot oops but you can inspect and see).

This allows for the text to be more fluid around tables, making UX better.

AmoleR avatar Dec 19 '21 21:12 AmoleR

Screenshot 2021-12-20 163343

I did this much with the alignment (this is a recreation of the wikipedia page) and I also added borders around images with the caption as well, like Wikipedia. This is my first time with this kind of stuff, so I'm not sure if I did the right thing.

theMetaHack avatar Dec 20 '21 21:12 theMetaHack

Also if you write a large caption it will fit the size of the image (so the caption is not wider than the image)

theMetaHack avatar Dec 20 '21 21:12 theMetaHack

image Like this

theMetaHack avatar Dec 20 '21 21:12 theMetaHack

Open a PR, but looks good. Ask @vEnhance for opinion on design as well.

AmoleR avatar Dec 20 '21 23:12 AmoleR

Yeah, submit a pull request so that it can be merged.

vEnhance avatar Dec 22 '21 00:12 vEnhance

I tried doing that, but the file I made changes in doesn't exist? Maybe it has something to do with the IDE or I'm not doing pull requests right (first time with Github). Specifically, I was editing CSS.

theMetaHack avatar Dec 22 '21 16:12 theMetaHack

@theMetaHack can you just send me the code and I'll commit it myself?

vEnhance avatar Sep 23 '22 18:09 vEnhance

@theMetaHack bump on this

vEnhance avatar Dec 02 '22 19:12 vEnhance

Unfortunately, my computer went faulty a few months ago and I lost all information on the drive where the code was stored. I'll try to recreate it.

theMetaHack avatar Dec 03 '22 19:12 theMetaHack

The chess board on the left hand side is a table, images like image have different classes. Also this is in 5 spades and 9 spades at the same time, does this make it a 14 spade :)

Incompleteusern avatar Jan 27 '23 16:01 Incompleteusern

Nah, you get max rather than sum when the price tags differ...

vEnhance avatar Jan 27 '23 17:01 vEnhance

Did you respond to the wrong email?

Incompleteusern avatar Jan 27 '23 17:01 Incompleteusern

I was replying to

Also this is in 5 spades and 9 spades at the same time, does this make it a 14 spade :)

vEnhance avatar Jan 27 '23 18:01 vEnhance

Wikipedia seems to also use float right? Don't really get what this is asking for? image

Incompleteusern avatar Mar 04 '23 04:03 Incompleteusern

Wikipedia seems to also use float right? Don't really get what this is asking for? image

Basically the tables are just wrapped in a float: right class right now. It's best to actually make a separate class for them and put in padding, border, etc. Make it look much better than what it does right now, because it's not that pretty.

If someone has a screenshot of current figures/tables on ARCH I can explain much better.

AmoleR avatar Mar 12 '23 04:03 AmoleR

ARCH?

Incompleteusern avatar Mar 12 '23 04:03 Incompleteusern

ARCH?

Isn't arch the wiki? Am I confusing something with something else?

ETA: It is not the wiki.

AmoleR avatar Mar 12 '23 04:03 AmoleR