micropython-ulab icon indicating copy to clipboard operation
micropython-ulab copied to clipboard

[FEATURE REQUEST]scipy-compatibility of cho_solve

Open v923z opened this issue 3 years ago • 2 comments

@vikas-udupa

Vikas, according to the documentation, https://docs.scipy.org/doc/scipy/reference/generated/scipy.linalg.cho_solve.html, the first argument of cho_solve is a tuple, while https://github.com/v923z/micropython-ulab/pull/391 implements it with a single matrix. I overlooked the issue at the time, but I think I would like to have scipy-compatibility. Do you want to look into this, or should I?

v923z avatar Jun 03 '21 08:06 v923z

For the moment, I implemented cho_solve such that it is compatible with numpy.linalg.cholesky function that has already been implemented. But in the long run, it is right to follow what is given in the documentation, just like you mentioned. However, I am unable to work on it at the moment due to other commitments. It would be great if you could go ahead and fix this. If not, I can fix this after a couple of weeks.

vikas-udupa avatar Jun 08 '21 14:06 vikas-udupa

@vikas-udupa OK, thanks for the feedback! I might take a stab at it.

v923z avatar Jun 08 '21 18:06 v923z