Zoltán Vörös
Zoltán Vörös
OK, so one thing we could do is add the `numpy`-incompatible keywords `offset` and `count` to `load`, so that you could start from a particular place, and read a given...
What you're saying here doesn't address the issue I mentioned earlier. If we add a keyword or something like that to `load`, then we cannot rely on the fact that...
Code added in https://github.com/v923z/micropython-ulab/tree/take
You seem to bail out, when the array is not dense, but I think your `INDEX_LOOP` actually handles the general case.
I think it's OK to not deal with `float` indices. Also, make this optional by defining a variable in `ulab.h`!
If I look at your `INDEX_LOOP`, I have the feeling that you can save half of the space, if you copy the bytes corresponding to the contents of the RAM...
As this is not a request for implementing a specific function, method, or feature, I would suggest to move this to the [discussion](https://github.com/v923z/micropython-ulab/discussions) section. I would be happy to consider...
Would one-dimensional indexing suffice? You could still index higher-dimensional arrays, I am asking about the dimension of the indexing array.
Thanks for taking a stab at it! > Here's a diff that implements indexing by u/int* valued arrays. The indexing array can be multi-dimensional but the indexed-array needs to be...
> That seems to gel quite well with your proposal of checking bounds up-front, a first pass could do bounds-checking, conversion of negative indices, and maybe even account for non-dense...