v8.dev icon indicating copy to clipboard operation
v8.dev copied to clipboard

iOS Build is failing

Open ackava opened this issue 5 years ago • 0 comments

Build fails after following instructions on https://v8.dev/docs/cross-compile-ios,

../third_party/inspector_protocol/crdtp/json.cc:290:18: error: implicit conversion from 'std::__1::numeric_limits<long long>::type' (aka 'long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion]
    if (value <= std::numeric_limits<int64_t>::max() &&
              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/inspector_protocol/crdtp/json.cc:107:3: note: in instantiation of member function 'v8_crdtp::json::(anonymous namespace)::JSONEncoder<std::__1::vector<unsigned char, std::__1::allocator<unsigned char>>>::HandleDouble' requested here
  JSONEncoder(C* out, Status* status) : out_(out), status_(status) {
  ^
../third_party/inspector_protocol/crdtp/json.cc:365:11: note: in instantiation of member function 'v8_crdtp::json::(anonymous namespace)::JSONEncoder<std::__1::vector<unsigned char, std::__1::allocator<unsigned char>>>::JSONEncoder' requested here
      new JSONEncoder<std::vector<uint8_t>>(out, status));
          ^
../third_party/inspector_protocol/crdtp/json.cc:290:18: error: implicit conversion from 'std::__1::numeric_limits<long long>::type' (aka 'long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion]
    if (value <= std::numeric_limits<int64_t>::max() &&
              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/inspector_protocol/crdtp/json.cc:107:3: note: in instantiation of member function 'v8_crdtp::json::(anonymous namespace)::JSONEncoder<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>::HandleDouble' requested here
  JSONEncoder(C* out, Status* status) : out_(out), status_(status) {
  ^

Github Action: https://github.com/ackava/v8-android-buildscripts/runs/722913223?check_suite_focus=true

Is there any option to ignore this warning?

ackava avatar May 30 '20 11:05 ackava