sampling-heap-profiler icon indicating copy to clipboard operation
sampling-heap-profiler copied to clipboard

npm install fails for node v14

Open jithinktom opened this issue 4 years ago • 4 comments

make: *** [Release/obj.target/sampling_heap_profiler/bindings/sampling-heap-profiler.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/jithin1992/.nvm/versions/node/v14.15.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
gyp ERR! System Darwin 19.4.0
gyp ERR! command "/Users/jithin1992/.nvm/versions/node/v14.15.0/bin/node" "/Users/jithin1992/.nvm/versions/node/v14.15.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/jithin1992/Documents/workspace/services/product-search/node_modules/heap-profile
gyp ERR! node -v v14.15.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok 
npm WARN [email protected] No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

jithinktom avatar Nov 30 '20 17:11 jithinktom

Having the exact same problem. @ofrobots

aliqaryan avatar Feb 01 '21 23:02 aliqaryan

Can you try with the alternative module https://github.com/google/pprof-nodejs?

ofrobots avatar Feb 02 '21 00:02 ofrobots

hello @ofrobots and @nolanmar511,

I have submitted a patch here that fixes the compilation issue:

#66

Please let me know if you have any feedback or reservations about merging this, I am happy to address.

michaele-blend avatar Nov 05 '21 22:11 michaele-blend

@michaele-blend @srubin

Please merge this PR to fix above node v14 issue: https://github.com/v8/sampling-heap-profiler/pull/57

ankursachdeva11 avatar Mar 04 '22 10:03 ankursachdeva11

This repo is being archived (see https://github.com/v8/sampling-heap-profiler/blob/master/README.md for more information).

Closing all issues in anticipation of this.

nolanmar511 avatar Sep 28 '22 17:09 nolanmar511