v6d icon indicating copy to clipboard operation
v6d copied to clipboard

Adapt k8s to v1.19.3.

Open dashanji opened this issue 1 year ago • 5 comments

What do these changes do?

  • Adapt k8s to v1.19.3.
  • ~~Replace the log package in go/vineyard with k8s/pkg/log.~~
  • Use the log implementation under k8s/pkg to replace the log implementation under go/vineyard.

Related issue number

Fixes #1651

dashanji avatar Feb 19 '24 03:02 dashanji

Replace the log package in go/vineyard with k8s/pkg/log.

Don't do that. The package go/vineyard is expected to be used as a standalone package and requiring k8s components/packages in such a data structure package looks quite wired.

sighingnow avatar Feb 19 '24 03:02 sighingnow

Ok, I will try to fix the version compatibility between go/vineyard/log and k8s/pkg/log.

dashanji avatar Feb 19 '24 04:02 dashanji

Sorry for the previous confusing description and please check the updated one. Actually, the [email protected] depends on a low version of github.com/go-logr/logr but the current log implementation in go/vineyard requires a high version. Thus, I implemented the log package in the go/vineyard and reused the logic in the k8s/pkg/log.

dashanji avatar Feb 19 '24 11:02 dashanji

The vineyard scheduler is closely related to the k8s version. As the scheduler configurations of lower versions will be deprecated in higher versions of k8s, we can't support multiple versions (v1beta1, v1beta2, v1beta3, and v1) of scheduler configuration in the same codebase.

A possible way is to find the lowest version of scheduler configuration and make sure it can work in the latest k8s cluster.

dashanji avatar Feb 20 '24 13:02 dashanji

/cc @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

github-actions[bot] avatar Mar 12 '24 00:03 github-actions[bot]