Vale comments

Results 13 comments of


                                            Vale

fix(type-safe-api): create a new asset with PrepareApiSpecOptions props and used it in PrepareApiSpecCustomResourceProperties instead or raw properties in order to avoid large payload that can cause the PrepareSpecCustomResource to fail

Hi @agdimech, Awesome! Because it's a sync lambda it as a payload limit to 6MB right? this is really good, I didn't understand why custom resource is made like this...

fix(type-safe-api): create a new asset with PrepareApiSpecOptions props and used it in PrepareApiSpecCustomResourceProperties instead or raw properties in order to avoid large payload that can cause the PrepareSpecCustomResource to fail

CloudFormation can indeed resolve !Ref !GetAtt etc, but it can't resolve `${Token}` like in the following ```json "getCompanies": { "integration": { "type": "AWS_PROXY", "httpMethod": "POST", "uri": "arn:aws:apigateway:eu-west-1:lambda:path/2015-03-31/functions/${Token[TOKEN.2257]}/invocations", "passthroughBehavior": "WHEN_NO_MATCH" },...

fix(type-safe-api): create a new asset with PrepareApiSpecOptions props and used it in PrepareApiSpecCustomResourceProperties instead or raw properties in order to avoid large payload that can cause the PrepareSpecCustomResource to fail

I'm sorry but I have really no idea of how to replace `Provider` and `CustomResource` with a `Trigger`. I never used it, there is no way to define the input...