edgeserver icon indicating copy to clipboard operation
edgeserver copied to clipboard

Adjust CI/CD to attach Git Metadata

Open lucemans opened this issue 3 years ago • 1 comments

lucemans avatar Jun 08 '22 13:06 lucemans

It occurs to me the Makefile looks like it's been replaced by the webpack build; should it be removed?

bvibber avatar Feb 17 '17 17:02 bvibber

Yes, originally started with a makefile, but then started using npm scripts cause easier. But now if the scripts start getting longer, it might make more sense to just use a separate make or build script again. Maybe remove for now?

brianxautumn avatar Feb 17 '17 17:02 brianxautumn

Actually it does make more sense to use makefile. Going move the build scripts to there. Just added a new one to build the ogv example

brianxautumn avatar Feb 17 '17 19:02 brianxautumn

My one warning on using a Makefile is that it's harder to make a local build that works on both Unix and Windows.

For ogv.js I'm planning to split out the emscripten-built modules, which require a Unix build infrastructure for all the autoconf libraries anyway, and avoid Makefiles on the front-end build in favor of Grunt.

bvibber avatar Feb 17 '17 21:02 bvibber

That is a very good point. Npm for now it is!

brianxautumn avatar Feb 17 '17 23:02 brianxautumn