goto icon indicating copy to clipboard operation
goto copied to clipboard

Atom not responding on 'cmd-shift-r'

Open daupawar opened this issue 8 years ago • 7 comments

I have installed goto on my Mac whenever i fire cmd-shift-r or cmd-alt-down Atom hangs, and i have to force close it. cmd-r works well.

daupawar avatar Jun 28 '16 04:06 daupawar

Same thing happens too me. cpu is maxed, helper ram is over 1GB... waited for a while and finally decided to kill it

eago99 avatar Jul 01 '16 17:07 eago99

Happens to me as well. Atom Stops working. Any Idea's?

sevmardi avatar Jul 21 '16 14:07 sevmardi

I managed to debug it and here is what i found:

  1. https://github.com/v3ss0n/goto/blame/8095c5b149571018f2f98dad9ff56507b6df176b/lib/symbol-generator.coffee#L64 this line generates insane amount of logs
  2. in combination with my pretty large locale files in json format - logging is pretty much all the atom process is busy with for a looong time.

@mkleehammer ? Don't want to create PR for one line.

anri-asaturov avatar Aug 01 '16 02:08 anri-asaturov

@anri-asaturov I'm afraid I'm not using Atom right now.

mkleehammer avatar Aug 01 '16 13:08 mkleehammer

Big projects take a long time for the package to index. Architecturally, the package relies on grammar parsing to identify symbols across your project, which both makes it very flexible and powerful and makes it challenging to optimize. Your best approach to make the package usable in large projects is to take advantage of the “More ignored names” option in your Goto settings to ignore parts of the app that you don’t need indexed. A hacky workflow is to make it ignore everything except for the specific part of the project you are working on, and then updating that setting when you start working on something else.

@anri-asaturov I removed the console.log line you mentioned, but I can confirm that the Goto: Project Symbol command still takes a long time to complete for larger projects.

acusti avatar Dec 11 '16 06:12 acusti

A couple more specific tips:

  • Make sure to include file extensions you don’t care about in your “More ignored names” options, like: .css .svg
  • You probably want to exclude your test files, which could look like tests (if all your tests are in a directory names tests) or *.test.js (if all of your test files have that suffix).

acusti avatar Dec 11 '16 06:12 acusti

This might be the same as issue #99, which has a fix now. @anri-asaturov I also had a similar problem with a large file. @acusti the issue is that the ignored files are still processed (unless they were in a folder that was ignored).

dansisan avatar Jan 12 '17 01:01 dansisan