v2ray-core icon indicating copy to clipboard operation
v2ray-core copied to clipboard

Feat: [app/dns] Support specifying domain matcher (`linear` or `mph`)

Open Vigilans opened this issue 3 years ago • 1 comments

This PR enables selection the domain matcher to use for DNS (the default linear, or mph used by routing module).

This PR is a continuation of https://github.com/v2fly/v2ray-core/pull/1977 and https://github.com/v2fly/v2ray-core/pull/1978, and is just lines of code once base PRs get merged.

Vigilans avatar Sep 12 '22 16:09 Vigilans

Codecov Report

Base: 38.82% // Head: 38.87% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (31b334a) compared to base (d3b50bb). Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
+ Coverage   38.82%   38.87%   +0.04%     
==========================================
  Files         606      615       +9     
  Lines       36285    36612     +327     
==========================================
+ Hits        14089    14234     +145     
- Misses      20661    20801     +140     
- Partials     1535     1577      +42     
Impacted Files Coverage Δ
app/dns/config.pb.go 11.02% <0.00%> (-0.15%) :arrow_down:
app/dns/dns.go 55.37% <41.66%> (-0.91%) :arrow_down:
infra/conf/synthetic/dns/dns.go 60.43% <100.00%> (+0.14%) :arrow_up:
transport/internet/udp/hub.go 73.61% <0.00%> (-4.17%) :arrow_down:
transport/internet/udp/hub_linux.go 12.50% <0.00%> (ø)
transport/internet/tcp/sockopt_linux.go 38.46% <0.00%> (ø)
transport/internet/domainsocket/dial.go 53.84% <0.00%> (ø)
transport/internet/filelocker_other.go 0.00% <0.00%> (ø)
common/platform/others.go 90.90% <0.00%> (ø)
transport/internet/sockopt_linux.go 10.81% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 12 '22 16:09 codecov-commenter

This PR has conflics now, could you reslove it?

AkinoKaede avatar Nov 30 '22 01:11 AkinoKaede

I've rebased it to the master branch.

Vigilans avatar Nov 30 '22 04:11 Vigilans

Thanks for your work

AkinoKaede avatar Nov 30 '22 06:11 AkinoKaede