v2ray-core icon indicating copy to clipboard operation
v2ray-core copied to clipboard

[v4] Fix: correct TCP keepalive sockopt names for darwin

Open EHfive opened this issue 3 years ago • 2 comments

This backports https://github.com/v2fly/v2ray-core/pull/1777 to dev-v4main branch.

EHfive avatar Jun 26 '22 11:06 EHfive

Codecov Report

Merging #1845 (99ca7af) into dev-v4main (ab6811e) will decrease coverage by 0.06%. The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           dev-v4main    #1845      +/-   ##
==============================================
- Coverage       44.55%   44.48%   -0.07%     
==============================================
  Files             485      485              
  Lines           29628    29628              
==============================================
- Hits            13200    13180      -20     
- Misses          15000    15017      +17     
- Partials         1428     1431       +3     
Impacted Files Coverage Δ
transport/internet/sockopt_darwin.go 36.36% <0.00%> (ø)
transport/internet/udp/dispatcher.go 64.76% <0.00%> (-12.39%) :arrow_down:
transport/internet/kcp/connection.go 69.61% <0.00%> (-2.21%) :arrow_down:
transport/pipe/impl.go 87.87% <0.00%> (-2.03%) :arrow_down:
transport/internet/kcp/listener.go 81.18% <0.00%> (-1.99%) :arrow_down:
transport/internet/kcp/receiving.go 98.65% <0.00%> (-1.35%) :arrow_down:
app/dns/dnscommon.go 87.12% <0.00%> (+0.75%) :arrow_up:
transport/internet/websocket/connection.go 20.18% <0.00%> (+3.66%) :arrow_up:
transport/internet/kcp/dialer.go 84.31% <0.00%> (+3.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab6811e...99ca7af. Read the comment docs.

codecov-commenter avatar Jun 26 '22 11:06 codecov-commenter

OK, force-pushed a commit with the same content to trigger the CI so the previous false failure on "Semgrep / Scan (pull_request) " could be eliminated, but the CI failed with another error on dev-v4main branch.

Error: ../../../go/pkg/mod/github.com/lucas-clemente/[email protected]/internal/qtls/go119.go:6:13: 
cannot use "The version of quic-go you're using can't be built on Go 1.19 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.19 yet. F...) as int value in variable declaration

I guess the version of quic-go on dev-v4main need to be updated.

/ping @AkinoKaede @xiaokangwang

EHfive avatar Sep 16 '22 05:09 EHfive

Closing as devs are not responding and I don't want to pay further energy on this. Feel free to pick it up.

EHfive avatar Oct 04 '22 22:10 EHfive