v2ray-core icon indicating copy to clipboard operation
v2ray-core copied to clipboard

Potential connection aborting when the transport is gRPC

Open mzz2017 opened this issue 3 years ago • 1 comments

Potential connection aborting when the transport is gRPC

https://github.com/v2fly/v2ray-core/blob/v5.0.6/transport/internet/grpc/dial.go#L62 The ctx should be context.Background() because "ctx is used for the lifetime of the stream." https://github.com/grpc/grpc-go/blob/v1.4.6/stream.go#L137-153 After ctx done, the stream would abort whether or not a data transfer was in progress.

Performance

For performance purpose, the globalDialerAccess.Lock() should not cover the grpc.Dial.

mzz2017 avatar May 13 '22 19:05 mzz2017

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Sep 11 '22 02:09 github-actions[bot]

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Jan 16 '23 02:01 github-actions[bot]