Vighnesh Shenoy

Results 67 comments of Vighnesh Shenoy

Okay, I created a few. You can edit and add them to the issue. @tomkerkhove But I also realize that there's too many of them. What's the smoothest way here...

> I'd create one umbrella issue, with tasks > > * [ ] scaler X > * [ ] scaler Y > > The task could be transferred into an...

> > > I'd create one umbrella issue, with tasks > > > > > > * [ ] scaler X > > > * [ ] scaler Y >...

@raorugan was trying the Kafka scaler recently and ran into the same problem. The workaround with setting `tls: enable` fixed it, without specifying cert, key.

We use the older Service Bus [sdk ](https://github.com/Azure/azure-service-bus-go). It only supports connection strings of the first type - ``` Endpoint=sb://.servicebus.windows.net/;SharedAccessKeyName=;SharedAccessKey= ``` and not ``` Endpoint=sb://.servicebus.windows.net;SharedAccessSignature=SharedAccessSignature sr=.servicebus.windows.net&sig=&se=&skn= ``` In fact, if...

Even though the docs mention `go1.18` this [package ](https://github.com/Azure/azure-sdk-for-go/)is already being used in the repo. - [Azure Key Vault](https://github.com/kedacore/keda/blob/c00294c85561dd2e109f0ccdb30cb247fe9526fa/pkg/scaling/resolver/azure_keyvault_handler.go#L24) - [Azure Monitor](https://github.com/kedacore/keda/blob/c00294c85561dd2e109f0ccdb30cb247fe9526fa/pkg/scalers/azure/azure_monitor.go#L27)

They migrated to `1.18` in March as per this [PR](https://github.com/Azure/azure-sdk-for-go/pull/17308/files). But I don't think they're using any of the new `1.18` features.

Honestly, it's confusing as to how this repo works to me. It's a monorepo with all of SDKs for multiple Azure offerings. Some of them have individual `go.mod` files, some...