uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

Handle `podman stop` correctly

Open mackdk opened this issue 8 months ago • 0 comments

What does this PR change?

This PR changes how java is invoked to ensure we correctly handle the podman stop command. Currently the stop signal is in fact not reaching the java process itself, since the main process is a shell.

Before:

~> podman stop cocoattestation-container 
WARN[0010] StopSignal SIGTERM failed to stop container cocoattestation-container in 10 seconds, resorting to SIGKILL 
cocoattestation-container

After:

~> podman stop cocoattestation-container 
cocoattestation-container

GUI diff

No difference.

  • [X] DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • [X] DONE

Test coverage

  • No tests: already covered

  • [X] DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24452

  • [X] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • [ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

mackdk avatar Jun 10 '24 08:06 mackdk