uyuni
uyuni copied to clipboard
Deprecate about page
What does this PR change?
- Renamed
AbouttoHelp - Removed elements "Overview" and "Sign In" from the
Helpsection - Added
API Documentationlink on the login page - Removed links "About" and "Copyright Notice" from login
- Removed the
Copyright Noticelink from the left navbar footer (both authenticated and not)
add description
GUI diff
No difference.
Before: Login page
Side Nav
After: Login page
Side Nav
- [x] DONE
Documentation
-
No documentation needed: add explanation. This can't be used if there is a GUI diff
-
No documentation needed: only internal and user invisible changes
-
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
-
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
-
(OPTIONAL) Documentation PR
-
[x] DONE
Test coverage
-
No tests: add explanation
-
No tests: already covered
-
Unit tests were added
-
Cucumber tests were added
-
[ ] DONE
Links
Issue(s): #18335 Port(s): # add downstream PR(s), if any
- [x] DONE
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
- [ ] No changelog needed
If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)
Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
- [ ] Re-run test "changelog_test"
- [ ] Re-run test "backend_unittests_pgsql"
- [ ] Re-run test "java_pgsql_tests"
- [ ] Re-run test "schema_migration_test_pgsql"
- [ ] Re-run test "susemanager_unittests"
- [ ] Re-run test "javascript_lint"
- [ ] Re-run test "spacecmd_unittests"
Before you merge
:wave: Hello! Thanks for contributing to our project. Acceptance tests will take some time (aprox. 1h), please be patient :coffee: You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8588/checks Once tests finish, if they fail, you can check :eyes: the cucumber report. See the link at the output of the action. You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8588/checks.
If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.
Reference tests:
-
https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule
-
https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule
KNOWN ISSUES
Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.
For more tips on troubleshooting, see the troubleshooting guide.
Happy hacking! :warning: You should not merge if acceptance tests fail to pass. :warning:
Suggested tests to cover this Pull Request
- min_salt_formulas_advanced
- min_deblike_monitoring
- min_virthost
- srv_change_task_schedule
- srv_create_repository
- min_config_state_channel
- srv_menu
- minssh_ansible_control_node
- srv_enable_sync_products
- min_action_chain
- proxy_branch_network
- srv_cobbler_profile
- min_bootstrap_negative
- minssh_salt_install_package
- min_rhlike_salt
- proxy_register_as_minion_with_script
- srv_virtual_host_manager
- srv_create_activationkey
- allcli_sanity
- min_timezone
- min_recurring_action
- min_bootstrap_api
- min_ansible_control_node
- srv_power_management
- min_salt_openscap_audit
- allcli_software_channels
- srv_payg_ssh_connection
- srv_check_sync_source_packages
- srv_cobbler_distro
- sle_ssh_minion
- allcli_reboot
- min_bootstrap_ssh_key
- sle_minion
- srv_content_lifecycle
- srv_datepicker
- srv_user_configuration_salt_states
- minssh_action_chain
- allcli_overview_systems_details
- srv_sync_channels
- srv_channels_add
- min_salt_pkgset_beacon
- srv_handle_config_channels_with_ISS_v2
- min_move_from_and_to_proxy
- min_salt_user_states
- buildhost_bootstrap
- srv_logfile
- srv_patches_page
- srv_clone_channel_npn
- srv_organization_credentials
- srv_custom_system_info
- srv_disable_local_repos_off
- min_deblike_ssh
- srv_sync_products
- srv_scc_user_credentials
- min_docker_api
- srv_distro_cobbler
- srv_cobbler_buildiso
- srv_add_rocky8_repositories
- min_config_state_channel_subscriptions
- minkvm_guests
- srv_maintenance_windows
- min_salt_install_with_staging
- srv_dist_channel_mapping
- srv_power_management_api
- minssh_bootstrap_api
- srv_activationkey_api
- proxy_as_pod_basic_tests
- srv_push_package
- srv_check_channels_page
- srv_docker_cve_audit
- srv_manage_channels_page
- min_rhlike_openscap_audit
- allcli_system_group
- min_activationkey
- min_deblike_remote_command
- min_project_lotus
- srv_notifications
- min_deblike_openscap_audit
- srv_restart
- srv_check_reposync
- min_salt_mgrcompat_state
- min_salt_software_states
- proxy_retail_pxeboot_and_mass_import
- srv_first_settings
- min_rhlike_salt_install_package_and_patch
- min_salt_migration
- min_bootstrap_script
- srv_salt
- min_rhlike_ssh
- min_salt_formulas
- minssh_move_from_and_to_proxy
- buildhost_osimage_build_image
- min_cve_id_new_syntax
- srv_user_preferences
- srv_cobbler_sync
- srv_channel_api
- srv_osimage
- min_salt_minions_page
- min_custom_pkg_download_endpoint
- srv_task_status_engine
- srv_monitoring
- srv_delete_channel_with_tool
- allcli_config_channel
- srv_docker
- srv_users
- srv_docker_advanced_content_management
- srv_rename_hostname
- srv_reportdb
- srv_wait_for_reposync
- allcli_action_chain
- allcli_software_channels_dependencies
- buildhost_docker_auth_registry
- min_bootstrap_reactivation
- srv_power_management_redfish
- proxy_cobbler_pxeboot
- min_ssh_tunnel
- buildhost_docker_build_image
- srv_mainpage
- allcli_update_activationkeys
- min_empty_system_profiles
- srv_advanced_search
- min_salt_minion_details
- min_rhlike_monitoring
- min_change_software_channel
- min_monitoring
- srv_handle_software_channels_with_ISS_v2
- srv_change_password
- srv_delete_channel_from_ui
- min_deblike_salt_install_with_staging
- min_deblike_salt
- srv_manage_activationkey
- min_cve_audit
- min_salt_install_package
- min_check_patches_install
- srv_salt_download_endpoint
- min_salt_lock_packages
- min_retracted_patches
- min_deblike_salt_install_package
- srv_group_union_intersection
- min_rhlike_remote_command
Please see the acceptance tests in the GH actions list, some of the tests need to be updated to account for this change.
This PR should include a changelog entry, please see https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository for a guide on how to add it.
Adding @uyuni-project/qe as reviewer. These UI changes will surely need to be committed together with test code changes. Keep in mind the tests passing in the GH actions are not all the tests we cover in CI, so better double check grepping into the testsuite folder for these changed words.
The main feature that needs adjustments is https://github.com/uyuni-project/uyuni/blob/master/testsuite/features/secondary/srv_mainpage.feature It would be also good if you replace
Scenario: Access the Copyright Notice
Given I am not authorized
When I go to the home page
And I follow "Copyright Notice"
Then I should see a "Copyright (c) 2011 - 2023 SUSE LLC." text
with the new API Documentation link/page you added.
Please remember to merge https://github.com/uyuni-project/uyuni/pull/8591 into this PR (just click on accept and rebase), or you will breat the tests by merging this one.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This PR was closed because it has been stalled for 10 days with no activity.
@bisht-richa We probably don't want to have this PR closed unmerged, right?