uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

Do not enable devel repos on proxy for released

Open mtravitzky opened this issue 1 year ago • 1 comments
trafficstars

What does this PR change?

This is a port of https://github.com/SUSE/spacewalk/pull/23738.

Sumaform does only add the devel repos for the proxy on nightly, PR and VM-nightly. However, the testsuite will try to enable these on any Proxy if the testing environment is not BV and has a private network (e.g. when running on the suma-05 testing server), no matter the version, which obviously fails on released.

This PR will prevent the enabling of these repositories on released, so released can be properly tested on the test server as well. Additionally, a method for retrieving the full version name has been added.

GUI diff

No difference.

  • [x] DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • [x] DONE

Test coverage

  • No tests: fixed existing tests

  • [x] DONE

Links

Issue(s): # Port(s): https://github.com/SUSE/spacewalk/pull/23738

  • [x] DONE

Changelogs

  • [x] No changelog needed

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

mtravitzky avatar Feb 21 '24 14:02 mtravitzky

:wave: Hello! Thanks for contributing to our project. Acceptance tests will take some time (aprox. 1h), please be patient :coffee: You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8354/checks Once tests finish, if they fail, you can check :eyes: the cucumber report. See the link at the output of the action. You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8354/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

  • https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

  • https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking! :warning: You should not merge if acceptance tests fail to pass. :warning:

github-actions[bot] avatar Feb 21 '24 14:02 github-actions[bot]

You should rebase this PR, to e.g trigger the PR tests again.

nodeg avatar Feb 26 '24 10:02 nodeg