uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

reposync: import GPG keys to RPM DB individually (bsc#1217003)

Open meaksh opened this issue 1 year ago • 2 comments

What does this PR change?

This PR refactors the code around GPG keys importing from Spacewalk keyring to the RPM DB that is used by Zypper during spacewalk-repo-sync execution:

  • GPG keys are processed individually, instead of all in the same file.
  • Continue processing keys even if there are errors in some of them.
  • Enhance related import logging.

GUI diff

No difference.

  • [x] DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • [x] DONE

Test coverage

  • No tests: already covered at accepteance tests. No unit tests for GPG keys import

  • [x] DONE

Links

Issue(s):

  • https://github.com/SUSE/spacewalk/issues/23150
  • https://github.com/uyuni-project/uyuni/issues/8176 (?)

Ports(s): https://github.com/SUSE/spacewalk/pull/23629

  • [x] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • [ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

meaksh avatar Feb 05 '24 12:02 meaksh

Hi ! We fixed a spelling mistake in the name of the tests and you will have to rebase your PR for the correct tests to run. Sorry for the inconvenience.

jordimassaguerpla avatar Feb 20 '24 15:02 jordimassaguerpla

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 30 '24 01:04 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar May 10 '24 01:05 github-actions[bot]