uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

Improvements in PostgreSQL parameterisation logic

Open sbluhm opened this issue 2 years ago • 7 comments

What does this PR change?

  • Allow parameterisation of min/max PostgreSQL version for Enterprise Linux same as for SUSE Leap.
  • Adapt usage of postgresql_version_max to allow minor versions. Otherwise max version would be limited to the major version itself (i.e. 15.0.0).
  • Remove creation of initdb symlink for Enterprise Linux to avoid package conflicts with PostgreSQL 15.
  • Replaced invalid use of Conflicts in spec file with Requires. "If the software links to the libraries of another package, it must use Requires: instead of Conflicts: to mark that dependency."

GUI diff

No difference.

  • [x] DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • [x] DONE

Test coverage

  • No tests: already covered

  • [x] DONE

Links

Issue(s): # Ports(s): # add downstream PR(s), if any

  • [x] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • [ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

sbluhm avatar Dec 24 '23 07:12 sbluhm

FYI @aaannz

sbluhm avatar Dec 24 '23 07:12 sbluhm

Looks good, but just to clarify and agree we are on the same page Initial idea was to use these variables to specify just one major version allowed.

Thank you for clarifying the understanding. I thought supplying "min" and "max" meant that you can use all versions that are allowed. For EL, I was planning to use/focus on v15 and stop working on/with v14. So your suggestion would work fine for me (until v16).

sbluhm avatar Jan 22 '24 10:01 sbluhm

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 08 '24 01:04 github-actions[bot]

@deneb-alpha i have the feeling that we have half of this already. Please check if we still need something of it.

mcalmer avatar Apr 08 '24 05:04 mcalmer

I am happy to close this request as I don't require it anymore. But I still think the elements should be corrected. Do feel free to close it if you disagree.

sbluhm avatar Jun 02 '24 06:06 sbluhm

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 02 '24 01:08 github-actions[bot]

@aaannz what do you think? We can probably close it

cbosdo avatar Aug 02 '24 07:08 cbosdo