uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

Form clear after delete

Open cbosdo opened this issue 2 years ago • 3 comments

Forward port of https://github.com/SUSE/spacewalk/pull/18448

What does this PR change?

Check if system has all formulas correctly assigned

When system has group formula assigned and user then edits this formula, we
need to assign edited formula as system formula as well for proper cleanup and
tracking.

Remove group formula assignments and data on group delete

GUI diff

No difference.

  • [X] DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • [X] DONE

Test coverage

  • Unit tests were added

  • [ ] DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/18421 and https://github.com/SUSE/spacewalk/issues/18422 Tracks # add downstream PR, if any

  • [ ] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • [ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

cbosdo avatar Aug 30 '22 12:08 cbosdo

@aaannz could you ensure that this is a good enough rebase of your 4.2 PR?

cbosdo avatar Aug 30 '22 12:08 cbosdo

Is this really needed for 4.3? In 4.2 we had two files for formulas which were not removed/cleared. But in 4.3 we just have database entries with cascades so IMO 4.3 is unaffected by the bugs reported against 4.2. Sure for unit tests, though.

aaannz avatar Sep 05 '22 10:09 aaannz

Is this really needed for 4.3? In 4.2 we had two files for formulas which were not removed/cleared. But in 4.3 we just have database entries with cascades so IMO 4.3 is unaffected by the bugs reported against 4.2. Sure for unit tests, though.

I'm not sure for master and 4.3 indeed.

cbosdo avatar Sep 05 '22 11:09 cbosdo

Just removed the code as it is indeed probably not relevant and adapted the unit tests.

cbosdo avatar Sep 26 '22 09:09 cbosdo