uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

Using a new user per feature

Open srbarrios opened this issue 3 years ago • 5 comments

What does this PR change?

Related to https://github.com/SUSE/spacewalk/issues/9748

Creating a new user per feature, using a scenario hook that will only pass for the first scenario per feature, acting as a feature hook.

It will by-pass the authentication of testing or admin users, using the regular step, when the feature variable @username is not null.

It creates a user name based on the feature filename because the feature name is too long and we have secondary features that acts on several clients during the same feature, so client name can't be use for that purpose on regular CI Tests.

How to debug parallel tests is another topic, that we can discuss and improve separetely. The aime of that PR is only to fix the current issue with multiple systems selected as described in the issue linked.

GUI diff

No difference.

  • [x] DONE

Documentation

  • No documentation needed

  • [x] DONE

Test coverage

  • Cucumber tests were changed, need to check on CI

  • [x] DONE

Links

None

  • [x] DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • [x] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_lint_checkstyle"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "ruby_rubocop"
  • [ ] Re-run test "schema_migration_test_oracle"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

srbarrios avatar Aug 05 '22 08:08 srbarrios

https://ci.suse.de/blue/organizations/jenkins/uyuni-prs-ci-tests/detail/uyuni-prs-ci-tests/1513/pipeline

srbarrios avatar Aug 05 '22 08:08 srbarrios

I approved it but am curious on how this has an impact on the performance. But let`s wait for Erics go/no go.

It will for sure increase a bit the time per feature. But, when we enable parallel tests this will be very compensated :)

srbarrios avatar Aug 11 '22 09:08 srbarrios

https://ci.suse.de/blue/organizations/jenkins/uyuni-prs-ci-tests/detail/uyuni-prs-ci-tests/1523/pipeline/

srbarrios avatar Aug 11 '22 10:08 srbarrios

Testing it: https://ci.suse.de/view/Manager/view/Uyuni-PRs/job/uyuni-prs-ci-tests-qe/27/console

srbarrios avatar Jan 05 '23 16:01 srbarrios

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 29 '23 01:10 github-actions[bot]

This needs a rebase and more testing with the new changes. I converted it to a draft again.

nodeg avatar Feb 02 '24 13:02 nodeg