uyuni icon indicating copy to clipboard operation
uyuni copied to clipboard

Add support for cobbler >= 3.3.3

Open meaksh opened this issue 2 years ago • 13 comments

What does this PR change?

This PR does the necessary adjustments to work with latest cobbler versions >= 3.3.3:

  • Adjust custom "sync_post_tftpd_proxies.py" cobbler module to new API.
  • Remove deprecated next_server cobbler setting in favor of next_server_v4 and next_server_v6.
  • Adjust names for available fence agents
  • Adjust testsuite scenarios to new fence agents names
  • extend the already implemented Cobbler steps to include checking for profiles
  • add tests for Cobbler buildiso

IMPORTANT NOTE: DO NOT MERGE THIS UNTIL COBBLER 3.3.3 IS PUSHED TO UYUNI AND HEAD

GUI diff

No difference.

  • [x] DONE

Documentation

Test coverage

  • No tests: already covered

  • [x] DONE

Links

Tracks https://github.com/SUSE/spacewalk/issues/16538 Fixes https://github.com/SUSE/spacewalk/issues/17250

  • [x] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • [ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • [ ] Re-run test "changelog_test"
  • [ ] Re-run test "backend_unittests_pgsql"
  • [ ] Re-run test "java_pgsql_tests"
  • [ ] Re-run test "schema_migration_test_oracle"
  • [ ] Re-run test "schema_migration_test_pgsql"
  • [ ] Re-run test "susemanager_unittests"
  • [ ] Re-run test "javascript_lint"
  • [ ] Re-run test "spacecmd_unittests"

meaksh avatar Mar 09 '22 16:03 meaksh

Do you want me to test the kickstart process on an Alma8 instance or is this expected to work? If yes, is this ready to test or should I wait?

sbluhm avatar Apr 01 '22 09:04 sbluhm

@sbluhm Sadly this is still not in a working state. Also we are blocked until I have resolved https://github.com/cobbler/cobbler/issues/3016 both upstream and downstream.

SchoolGuy avatar Apr 04 '22 06:04 SchoolGuy

@SchoolGuy thanks for the info. Offer still holds. Just let me know if/when.

sbluhm avatar Apr 04 '22 07:04 sbluhm

@SchoolGuy, @meaksh: FYI: I have created my Cobbler buildiso tests against this branch and opened another PR for it: #5142. When you are ready with this PR, please merge my PR first into master-fixes-for-new-cobbler and then merge yours into master.

nodeg avatar Apr 04 '22 10:04 nodeg

@meaksh I found out that uyuni/utils/spacewalk-hostname-rename utilises the old settings file. Thus this change is missing on this PR. I will prepare a commit for this later.

SchoolGuy avatar Apr 22 '22 09:04 SchoolGuy

I rebased this onto master and pushed a few of my WIP changes along the way. Let's see how the testsuites like that while I continue implementing the new additional object features.

SchoolGuy avatar Jun 08 '22 06:06 SchoolGuy

Rebased onto master to solve the conflicts.

SchoolGuy avatar Jun 21 '22 06:06 SchoolGuy

@sbluhm I am not 100% sure but I believe testing this PR is of interest for you.

SchoolGuy avatar Jul 18 '22 14:07 SchoolGuy

YES! So I guess it is ready for testing? Unfortunately EL9 doesn't install anymore due to a PostgreSQL issue so might take some time.

sbluhm avatar Jul 18 '22 14:07 sbluhm

@sbluhm Yes it is. It will be merged for SUMA 4.3.1 so this week if my colleagues agree.

SchoolGuy avatar Jul 18 '22 15:07 SchoolGuy

@SchoolGuy ok that is probably a bit tight for me. So will test in my own time and submit changes to master as usual. Thanks for this one!

sbluhm avatar Jul 18 '22 18:07 sbluhm

@sbluhm Since some test failed we pushed this to 4.3.2, thus you know have a lot of time to test. I don't expect changes in the code atm, only fixes to the Java Unit-Tests. Feel free to prove me wrong. :D

SchoolGuy avatar Jul 29 '22 08:07 SchoolGuy

@sbluhm Addendum: I prepared a project for you to test - https://build.opensuse.org/project/show/home:SchoolGuy:branches:systemsmanagement:Uyuni:Master

SchoolGuy avatar Jul 29 '22 09:07 SchoolGuy

This seems stable enough now. Merging it now.

SchoolGuy avatar Aug 30 '22 11:08 SchoolGuy