Fix(CLM): Refresh channel state after errata filtering (bsc#1253007)

[wweellddeerr]

What does this PR change?

It fixes the following scenario:

During a CLM build, alignPackages() may add packages to the Channel entity in memory, while alignErrata() filters data by running direct SQL DELETE statements to remove denied errata and their packages. When that happens, the Hibernate session and the in-memory Channel object aren’t aware of those direct deletions, leaving the object stale. As a result, alignPackageCache() computes the delta based on this outdated state (which still includes the deleted packages), incorrectly marking them as “new” and inserting them into the system cache.

~~Solution: Trigger a HibernateFactory.getSession().refresh(tgt) call immediately after alignErrata() to ensure the target channel is in sync with the latest changes.~~

Solution: manually refresh in memory target channel packages list to be according to DB. Using refresh() triggers polymorphic type mismatches (Channel vs ClonedChannel), which result in Hibernate PropertyAccessException.

Codespace

Check if you already have a running container clicking on

GUI diff

No difference.

• [x] DONE

Documentation

• No documentation needed: only internal and user invisible changes

• [x] DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

• No tests: already covered

• [x] DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/28827

• [x] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• [ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• [ ] Re-run test "changelog_test"
• [ ] Re-run test "backend_unittests_pgsql"
• [ ] Re-run test "java_pgsql_tests"
• [ ] Re-run test "schema_migration_test_pgsql"
• [ ] Re-run test "susemanager_unittests"
• [ ] Re-run test "frontend_checks"
• [ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions[bot]]

:wave: Hello! Thanks for contributing to our project. Acceptance tests will take some time (aprox. 1h), please be patient :coffee:

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/11294/checks Once tests finish, if they fail, you can check :eyes: the cucumber report. See the link at the output of the action. You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/11294/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking! :warning: You should not merge if acceptance tests fail to pass. :warning: