minima icon indicating copy to clipboard operation
minima copied to clipboard

Added cleanup feature for MUs and SCC repositories

Open atighineanu opened this issue 3 years ago • 4 comments

Related card: https://github.com/SUSE/spacewalk/issues/15435

Added cleanup feature for MUs and SCC repositories

without this patch users will have to delete manually all the ibs:/ (MUs) and SCC (normal products, updates and installers repos) folders manually. This feature will be used separately depending on the kind of run. For SCC:

./minima sync --cleanup --auto-approve

For MUs:

./minima updates --cleanup --auto-approve

If you want to cherry-pick which of the undeclared in yaml repositories you want to keep, run:

./minima updates --cleanup 

---> you will be prompted to chose with y/n for each undeclared in minima config yaml repository what to do with it.

atighineanu avatar Sep 17 '21 09:09 atighineanu

it looks good to me, and this will be utterly useful, thanks

but i cannot judge the details of the code, and I think the correct person to approve is Silvio

just add doc before, please

Same for me, I don't know Golang that much but as a feature it's great :)

ktsamis avatar Sep 17 '21 09:09 ktsamis

@moio @rjmateus hey guys, I guess you could also take a quick look here. I've nitpicked a couple of small things to be changed in the PR, but I'm not sure how important would it be to take care of the code style for such a project? I believe there's some optimization potential there.

avshiliaev avatar Jun 10 '22 11:06 avshiliaev

@moio Onee thing puzzles me here. I cannot found where this method should come from :smiley:

avshiliaev avatar Jun 10 '22 11:06 avshiliaev

@moio Onee thing puzzles me here. I cannot found where this method should come from 😃

It was supposed to be a method in get/gcp.go, addressing the same kind of functionality against gc storage (was a WIP). Right now it is in fact obsolete.

atighineanu avatar Jun 10 '22 12:06 atighineanu