TreeShrink icon indicating copy to clipboard operation
TreeShrink copied to clipboard

Node label transfer error at rooting point

Open dfmoralesb opened this issue 5 years ago • 4 comments

Hi. I notice that when working with trees that have node label (e.g. from bootstrap support) the label from the random node where TreeShrink reroots the tree to do the pruning does not get transfer to the pruned tree. So, when rerooting the pruned tree to the correct root there is a node in the ingroup that is missing the node label.

Thanks, Diego

dfmoralesb avatar May 14 '19 20:05 dfmoralesb

Hello Diego,

Thank you for pointing out the issue. Because the bootstrap support would not make sense after the tree has some taxa removed, we do not keep track of them in the pruned tree. In future release we will remove all the internal node label to avoid the confusion.

I hope this help!

uym2 avatar Jun 04 '19 17:06 uym2

Is this done?

smirarab avatar Jun 03 '20 20:06 smirarab

I also notice my tree needs to be rerooted after processing.

tseemann avatar Jun 10 '20 22:06 tseemann

Uyen, would be good to keep the rooting fixed. I agree with you that internal node labels loose their meaning and should be removed. But, if the gene tree is experiencing no removal, it seems wise to keep the BS.

On Wed, Jun 10, 2020 at 3:11 PM Torsten Seemann [email protected] wrote:

I also notice my tree needs to be rerooted after processing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uym2/TreeShrink/issues/9#issuecomment-642294055, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJXOAG4HLEAKSRCKKFZUDRWAAHLANCNFSM4HM5JQLQ .

-- Siavash Mirarab

smirarab avatar Jul 02 '20 16:07 smirarab