osr2mp4-core
osr2mp4-core copied to clipboard
Spinners incorrectly increment combo color
In the osu! client, spinners don't move the combo color forward even though they're treated as their own combos. In osr2mp4 every time there's a spinner the combo color gets shifted incorrectly forward by one. This is pretty bad if there are color hax.
ComboOffset bits also shouldn't do anything if on a spinner, and the notes after the spinner should always be a new combo (the editor will correct these errors on save ppy/osu-stable-issues#733 )
@alchzh oh never noticed that thank you
At 0:37 in this replay https://streamable.com/9kpy9d from this post https://www.reddit.com/comments/qoayac, a followpoint is visible connecting an object before the spinner to one after the spinner. The next combo also starts at 2. I haven't checked if this is just 2007 map jank though.
There's also a couple examples later on of followpoints appearing over a break from the upper-left corner, usually when a spinner was the last object before the break