Beartama

Results 66 comments of Beartama

I don't think we need a JSON parser in Catch2 code, we only need to use the CMake JSON parser for parsing the tests and tags.

@nilsvu yes, you can follow the progress of https://github.com/catchorg/Catch2/pull/2706 for the JSON reporter, after the reporter is done, then this should be trivial.

@horenmar This PR is complete now, as soon as #2706 is complete, this PR should be good to merge too.

> Is there any progress on this? I currently am not working on this (no idea when I will resume), so I hope someone can pick this up or maybe...

I think only the comments from @horenmar above and that should be it.

so adding the following overloads makes it work, but I wonder why this is not done automatically? ```cpp template auto sol_lua_check(sol::types, lua_State *L, int index, Handler &&handler, sol::stack::record &tracking) ->...

sorry, I was using my work account to comment, so I removed that, I'll still keep working on a PR though.

```cpp static_assert(hour != metre); // Compiles fine ``` I'm actually surprised this compiles since it looks nonsensible, quantities having different units should be incomparable, not just different. So I think...

I think it's better to have a function to ask if 2 quantity is comparable (concept even) not fusing it with the compilability of the `operator==` and `operator!=`

I'm not sure what you're trying to achieve here, shouldn't something like [this](https://godbolt.org/z/9j3oKsWGG) be enough?