bootstrap-datepicker icon indicating copy to clipboard operation
bootstrap-datepicker copied to clipboard

bootstrap 4 support

Open acrobat opened this issue 10 years ago • 20 comments

Bs4 is still in early alpha but when it reaches beta (no api changes after beta) we should take a look into adding a bs4 stylesheet and ~~possibly~~ deprecate bs2 support

acrobat avatar Nov 13 '15 07:11 acrobat

possibly deprecating bs2 support

would drop support for bs2 with the first version supporting bs4

hebbet avatar Nov 13 '15 10:11 hebbet

Yes you are right @hebbet, bs2 is not supported by the twbs team so we should drop it too when moving to bs4

acrobat avatar Nov 13 '15 12:11 acrobat

Is there any progress on this side at the moment? We are using bootstrap4-alpha3 pretty heavily already and i would suggest it could make sense migrating this also? We have been using bootstrap-datepicker with bootstrap2 and would love continuing to do so.

What are the expected working-areas to adjust the datebicker? are those mostly theme / css related things?

EugenMayer avatar Aug 10 '16 07:08 EugenMayer

I haven't looked into detail on what should/must change, but my first idea is that we would need to switch some classes and provide a bs4 stylesheet

acrobat avatar Aug 10 '16 07:08 acrobat

Well if you guys could guide me a little bit, we could try to do some first attempts here to see, how "low hanging fruits" this topic might be and what concrete issues would arise. What do you think?

EugenMayer avatar Aug 10 '16 08:08 EugenMayer

@EugenMayer all help is welcome! Maybe you could just load up a bs3 datepicker in the new bs4 style and see what styles are wrong and start making a list of classes/styles (in a separate issue) we should change. That way we have already an idea on how much work this will be

After that we can start on a plan what steps we should take (the introduction of themes is one of those)

acrobat avatar Aug 10 '16 08:08 acrobat

Perfect, will do that and report back. We will try to see what we can fix and show off those things using pull requests to see, how things work out

EugenMayer avatar Aug 10 '16 08:08 EugenMayer

That's great @EugenMayer, thanks!

acrobat avatar Aug 10 '16 08:08 acrobat

This will be done when the backends stuff is done. Not that in my hand I won't create a backend that support BS4, tho I'll create on for BS2, mainly because I do still use BS2 on some projects.

Azaret avatar Oct 20 '16 21:10 Azaret

Since others are referencing this issue mentioning that it works but isn't officially supported and bootstrap4 has been stable for quite some time, when do you expect to make it officially support bootstrap4?

johan-bjareholt avatar Jul 21 '17 16:07 johan-bjareholt

bootstrap is no close to stable - still :) lets talk about it 2020, when a first rc1 probably gonna hit the public.

hint to myself: https://github.com/twbs/bootstrap/milestone/41 beta1 probably even about to happen! 4 issues left, i am a bit suprised

hint2: oh.. https://github.com/twbs/bootstrap/issues/20631 somebody finally opened their eyes, wonderful!

EugenMayer avatar Jul 21 '17 16:07 EugenMayer

I gave up on bootstrap completely about 6 months ago and happy! Use semantic-ui or material.

alvipeo avatar Jul 21 '17 18:07 alvipeo

Wow, I didn't know it was this bad. I was using bootstrap-vue which is the only vue2 plugin which uses bootstrap and it used bootstrap4 so i assumed it was stable.

johan-bjareholt avatar Jul 21 '17 20:07 johan-bjareholt

@johan-bjareholt, I'm in the exact same situation. Using bootstrap-vue and looking for a Bootstrap 4 datetimepicker.

ndabAP avatar Jul 24 '17 05:07 ndabAP

Bootstrap 4 has just gone beta today. Happy coding!

ieugen avatar Aug 11 '17 08:08 ieugen

Hey guys, how stable is BS4 support right now? (for the beta version)

gustavostuff avatar Sep 14 '17 16:09 gustavostuff

At this point we should be able to start work on bs4 support ideally with some sort of theme support so we can easily support bs3 and bs4 (and even other themes if necessary).

I don't have the time (and js knowledge) to start work on this feature. Therefor I've opened #2252 to request some extra helper from active JS developers. This way we can, hopefully, get more feature implemented and bugs fixed! So any idea's and development help are welcome!

acrobat avatar Sep 14 '17 16:09 acrobat

Any progress?

NSExceptional avatar Nov 18 '18 23:11 NSExceptional

maybe same as #1574

ttskch avatar Jan 30 '20 14:01 ttskch

Let's specify on the readme that BS4 isn't supported so that people like me don't have to beat their head. It says it needs BS2.0.4+ on the RTD, I assumed that it would support BS4.

aasutossh avatar Oct 07 '20 14:10 aasutossh