bootstrap-datepicker icon indicating copy to clipboard operation
bootstrap-datepicker copied to clipboard

Clicking outside the datepicker to close it uses mousedown, so won't work on mobile

Open peterjwest opened this issue 9 years ago • 7 comments

I can't see any immediately obvious reason why this click wouldn't work as a direct substitute.

peterjwest avatar Oct 13 '15 13:10 peterjwest

This was already solved in Release 1.3.0 #481, but somehow now it’s not in the code anymore. See also 511c1b0241eb9804892df6f9388e0afd00107253.

gchtr avatar Oct 14 '15 09:10 gchtr

@peterjwest: what version of datepicker do you use?

hebbet avatar Oct 19 '15 15:10 hebbet

Just looking through the code on master and latest release https://github.com/eternicode/bootstrap-datepicker/blob/v1.5.0/js/bootstrap-datepicker.js#L423

peterjwest avatar Oct 19 '15 15:10 peterjwest

This #820 and this #1284.

Azaret avatar Oct 19 '15 17:10 Azaret

I guess this PR was merged a bit too quickly. The issue was more that the check to see if touchstart was out of the datepicker wasn't working. I can look into this @hebbet

Azaret avatar Oct 19 '15 17:10 Azaret

After few tests, it looks like before #1284, it worked as expected, meaning the picker close only when the screen is touched out of the picker.

So the call here would be to choose:

  • Close on touchstart like <1.3.0
  • Do not close on touchstart
  • Give the option to close or not on touchstart (and maybe on mousedown)
  • Give the option to show a close button

Imo it would be interesting to work more on the mobile integration, maybe open a new ticket for this, there is much to say.

Azaret avatar Oct 19 '15 20:10 Azaret

This is still open? o.o

35grain avatar Sep 06 '22 12:09 35grain