oneAPI-spec
oneAPI-spec copied to clipboard
Add transpose routines to BLAS-like extensions
This PR adds transpose and batch-transpose BLAS-like extensions imatcopy, omatcopy, omatadd, imatcopy_batch, omatcopy_batch, and omatadd_batch to the spec.
@aaronjohnson I addressed your comments and added the table you suggested, let me know what you think.
@andrewtbarker is this good to merge?
@mmeterel we have a TAB meeting on these changes next week, I think it makes sense to wait until after the meeting to merge.
@aaronjohnson @mmeterel @lhuot @spencerpatty I've modified the spec based on feedback from TAB and others:
- Added documentation of in-place use of
omataddto doC += alpha Aand other previously unsupported cases; - ~Added
geamas a simple wrapper aroundomatadd;~ - Added
omatcopy2because it was missing from spec; - More uniform references to strided-batch and group-batch for all the APIs.
I'd appreciate any comments or suggestions.
In my view this is ready to merge - let me know if you have any concerns.
@spencerpatty I made most of the changes you suggested (add "dense" and use "specify" instead of "implement") in several places. Regarding transpose options: I clarified the transpose datatype description here, which is referenced multiple times from the spec, but I left the individual pages because their description of the transpose parameters is consistent with elsewhere in the spec (ie blas::gemm).