oneAPI-spec icon indicating copy to clipboard operation
oneAPI-spec copied to clipboard

Add transpose routines to BLAS-like extensions

Open andrewtbarker opened this issue 3 years ago • 3 comments

This PR adds transpose and batch-transpose BLAS-like extensions imatcopy, omatcopy, omatadd, imatcopy_batch, omatcopy_batch, and omatadd_batch to the spec.

andrewtbarker avatar Jun 13 '22 22:06 andrewtbarker

@aaronjohnson I addressed your comments and added the table you suggested, let me know what you think.

andrewtbarker avatar Jun 14 '22 22:06 andrewtbarker

@andrewtbarker is this good to merge?

mmeterel avatar Jul 20 '22 17:07 mmeterel

@mmeterel we have a TAB meeting on these changes next week, I think it makes sense to wait until after the meeting to merge.

andrewtbarker avatar Jul 20 '22 17:07 andrewtbarker

@aaronjohnson @mmeterel @lhuot @spencerpatty I've modified the spec based on feedback from TAB and others:

  1. Added documentation of in-place use of omatadd to do C += alpha A and other previously unsupported cases;
  2. ~Added geam as a simple wrapper around omatadd;~
  3. Added omatcopy2 because it was missing from spec;
  4. More uniform references to strided-batch and group-batch for all the APIs.

I'd appreciate any comments or suggestions.

andrewtbarker avatar Aug 16 '22 22:08 andrewtbarker

In my view this is ready to merge - let me know if you have any concerns.

andrewtbarker avatar Aug 25 '22 16:08 andrewtbarker

@spencerpatty I made most of the changes you suggested (add "dense" and use "specify" instead of "implement") in several places. Regarding transpose options: I clarified the transpose datatype description here, which is referenced multiple times from the spec, but I left the individual pages because their description of the transpose parameters is consistent with elsewhere in the spec (ie blas::gemm).

andrewtbarker avatar Sep 06 '22 22:09 andrewtbarker