Janne Kurkinen

Results 91 comments of Janne Kurkinen

Vue 3.0 is stable now, jej! 🎉 How is the upgrade plan looking like?

@sholladay alright, so I have narrowed the issues' appearance after upgrading from 0.28.2 to 0.28.3

So it seems that this is related to that 1 millisecond wait on this commit: https://github.com/sindresorhus/ky/commit/5f3c3158af5c7efbb6a1cfd9e5f16fc71dd26e36

https://github.com/sindresorhus/ky/issues/345

@szmarczak interesting wait function syntax! However its not working on TS as `queueMicrotask` types are waiting for a callback function. I did make a temporary fix by running `await sleep(2);`...

@szmarczak ah, there was a type parameter, so this is working and is nice clean syntax 👍 ```ts await new Promise(queueMicrotask); ``` I have the sleep function in custom utilities,...

So it seems our implementation, although restricted by `vuex-oidc` / `oidc-client-js` libraries with which we need to run fetch in event handler callback function code, and there is only one...

Sorry, it seems `queueMicrotask` await is not lengthy enough a duration. I seem to have missed something when testing this last night.

Ah, actually I misread type signature for this hook: https://github.com/sindresorhus/ky/blob/764bc1cdabdb65bbcd9830b0f8bfbd95fed3179a/index.d.ts#L16-L22 However, this really limits what can be done in beforeRetryHook... Basically I can't even modify headers. So documentation doesn't reflect...

@sholladay thanks for your input. Indeed, this turned out to be feature request. Any chances of getting it implemented soon? In the mean time we just might implement the query...