gerrit-rest-java-client icon indicating copy to clipboard operation
gerrit-rest-java-client copied to clipboard

Consider using testcontainers and the gerrit docker images for "real" tests of code.

Open PMooreWand opened this issue 2 years ago • 1 comments

Not really an issue as closer to a discussion point. I maintain a similar project as part of testing a modified gerrit code base with my work. As part of testing that client I've employed the TestContainers package and spin up real gerrit instances on docker as part of the verify step in maven. I've noticed the RealServerTest class and have used it when working out the PR's I've sent in here, and I was wondering if an integration suite utilising gerrit docker is something this project would be interested in? Source of current usage I am referring to is here, I use this project's client to prep system for testing the client I'm running. https://github.com/WANdisco/gerrit-sshd-java-client/blob/main/src/test/java/integration/utils/TestBase.java

PMooreWand avatar Aug 20 '23 16:08 PMooreWand

Thanks for sharing this idea. I agree, this would make a lot of sense.

Feel free to provide a PR - happy to review it! :)

uwolfer avatar Aug 24 '23 19:08 uwolfer