gerrit-intellij-plugin icon indicating copy to clipboard operation
gerrit-intellij-plugin copied to clipboard

Allow for reviewing of projects that you have not checked out

Open rvowles opened this issue 11 years ago • 7 comments

Hi Urs - the front page says

"By default, you will only see changes to Git repositories that are configured in the current project of your IntelliJ IDE."

Is there a way to let you do reviews of projects that are not checked out? It would be extremely useful to be able to see a list of reviews that need doing and if they are on projects you aren't working on but have experience in, being able to do reviews without having to go to the Web UI.

rvowles avatar Jun 04 '14 21:06 rvowles

You can list changes which are not loaded in the IntelliJ project which is open currently (and do some actions), but: you cannot view diffs. This is what you want, right?

uwolfer avatar Jun 05 '14 18:06 uwolfer

Yes, this is what we were hoping for...

rvowles avatar Jun 05 '14 21:06 rvowles

Would something like right click on a review that's of an non-checked out project and select "clone", and automate the flow of 1) creating an empty/temp directory somewhere, 2) fetch the remote/branch from gerrit into it ( shallow fetch/clone maybe? ), 3) add/open the project to Idea 4) review and profit.

At least this way you'd make the barrier to doing a review minimal...

talios avatar Jun 05 '14 22:06 talios

I presume you would have to do this because it is an IDEA problem that you can't do diffs without the files being on disk?

rvowles avatar Jun 05 '14 23:06 rvowles

IMHO you can also get diffs with the Gerrit REST API, but I don't know it there is a clean way to display them in IntelliJ diff viewer.

Cloning changes from projects which are not checked out could take quite some time for larger projects.

uwolfer avatar Jun 06 '14 18:06 uwolfer

Cloning changes from projects which are not checked out could take quite some time for larger projects

That was the main reason for suggesting a shallow clone, if you're only taking the top level commits, it shouldn't take TOOOO long to checkout, at least - you wouldn't be pulling down the entire history.

talios avatar Jun 09 '14 01:06 talios

IMHO you can also get diffs with the Gerrit REST API, but I don't know it there is a clean way to display them in IntelliJ diff viewer.

Personally, I'd much more prefer to use the Gerrit REST API to retrieve the diff and possibly display it in a sub-optimal way than having to (shallow) clone the repo to get a potentially nicer diff. The latter just doe snot seem worth the effort to me.

sschuberth avatar Jan 31 '17 21:01 sschuberth