gerrit-intellij-plugin icon indicating copy to clipboard operation
gerrit-intellij-plugin copied to clipboard

Submit including parents

Open ThrashAbaddon opened this issue 7 years ago • 4 comments

I've noticed we don't have the feature to submit including parents. Is it possible to add that feature?

ThrashAbaddon avatar Nov 10 '17 09:11 ThrashAbaddon

@ThrashAbaddon How do you execute this action in the web UI? Is it a special submit action?

uwolfer avatar Nov 11 '17 16:11 uwolfer

Hi @uwolfer ,

I've by mistake used the word with instead of including parents. The labels are described here but the mentioned one says

change.submitLabelWithParents Label name for the submit button if the change has parents which will be submitted together with this change.

Default is "Submit including parents".

I don't know have you seen this button before but if I push a couple of commits with different change-id then the gerrit restricts submiting of commits that weren't reviewed because they are seen as a group. After all of them are reviewed someone can select any commit from that group and click Submit including parents. Then all commits will get merged/rebased to git repository behind gerrit.

ThrashAbaddon avatar Nov 13 '17 16:11 ThrashAbaddon

@ThrashAbaddon: What happens when you use the normal submit action (existing in this plugin) for a change which has parents? Does it fail?

uwolfer avatar Nov 26 '17 15:11 uwolfer

@uwolfer I'm not sure. When the situation occurs I'll try it out and write here the result. Unfortunately I don't have the permissions to create new branches on gerrit for testing purposes.

ThrashAbaddon avatar Dec 14 '17 08:12 ThrashAbaddon