plain_fsm icon indicating copy to clipboard operation
plain_fsm copied to clipboard

Published 20 hours ago • verified publisher icon uwiger

Fix badmatch in xform

Open attah opened this issue 4 years ago • 4 comments

The function maybe_add_vsn_f/1 reused the variable Anno, which resulted in a badmatch when the data_vsn/1 callback is not present.

attah avatar Feb 03 '21 16:02 attah

So shouldn't also Liine2 be made into an Anno?

uwiger avatar May 24 '21 12:05 uwiger

Possibly. Probably, even. I did however have no issues running it as posted - and i was just trying to make a minimal change to have it work properly.

Do you want the PR amended with that, or will you make a better change on your end?

attah avatar May 24 '21 17:05 attah

So it seems erl_anno:new() is a no-op, for both line-only and line+col notation. But it might not stay that way...so this should be reasonably future-prroof and readable.

attah avatar May 31 '21 14:05 attah

Anything else i should fix to make this merge-able?

attah avatar Aug 20 '21 13:08 attah

Sorry for the delay. Merged.

uwiger avatar Oct 31 '22 08:10 uwiger