Ulf Wiger
Ulf Wiger
@elbrujohalcon feels like cheating, but you're right - I couldn't easily come up with a refactoring that wouldn't be less readable than the existing code. :)
BTW, I noticed issue inaka/apns4erl#205, which has been around for a while. Since `gun` defaults to sending keepalives every 5 seconds, I assume that the problem should be resolved. OTOH,...
As I understand it, the code coverage is reduced due to the changes related to the proxy setup. There don't seem to be any proxy-related test cases in the connection_SUITE.
Since dialyzer run on the test code complained, I moved the gun options under a separate options key.
> How did you get to a keepalive value of 10000? Trial and error? I'm looking into increasing the default to something more reasonable. I only used 10 seconds in...
Please also update doc/overview.edoc
> Perhaps the nonce_offset should be set to at least the expected number of TXs that can fit in a single MB? 🤔 A reasonable check could be to do...
Closing, as the current GC implementation (most recent merged PR: #4147) persistently notes the last GC scan.
I noticed that there are no quickcheck tests for maps, so I started adding some. This highlighted that some more implementation is needed – not least prefix encoding.
I started working on it. I got pretty far, but then – after starting a 1M test run of prop_sort(), discovered that the keysort order in maps differs from the...