jare icon indicating copy to clipboard operation
jare copied to clipboard

Refactored changes to balance responsibility and reduce code duplication

Open Vatsalyadav opened this issue 2 years ago • 0 comments

  1. Created respective classes for providing ClassUtility depending on the data type
  2. Child classes of GenericAction, i.e., MathAction and DateAction have same implementation for setValue and setValue implementation is pulled up to the parent layer
  3. Extract MathActionTrigonometry, MathActionArithmeticOperations and MathActionOperations classes for methods relevant to Arithmetic, Trigonometry and Operations respectively.
  4. Extract checkNullForConcat method for duplicate code to check null in concatValues
  5. Rename XmlRule variables as per responsibility and behaviour

Vatsalyadav avatar Mar 25 '22 18:03 Vatsalyadav