ASCII-generator icon indicating copy to clipboard operation
ASCII-generator copied to clipboard

getsize in PIL dosen't work anymore

Open AvivHamagniv69 opened this issue 3 years ago • 1 comments
trafficstars

in /ASCII-generator/utils.py at char_width, char_height = font.getsize("A") PIL says getsize is deprecated and will be replcaed in PIL 10, error message:

DeprecationWarning: getsize is deprecated and will be removed in Pillow 10 (2023-07-01). Use getbbox or getlength instead.
  char_width, char_height = font.getsize(sample_character)

how to replicate the error:

python3 img2img.py --language chinese

i don't understand PIL a lot and i couldn't find what getsize does so hopefully someone else can fix this.

AvivHamagniv69 avatar Nov 25 '22 17:11 AvivHamagniv69

Replace char_width, char_height = font.getsize("A") with:

char_bbox = font.getbbox("A")
char_width = char_bbox[2] - char_bbox[0]
char_height = char_bbox[3]

It's really char_height = char_bbox[3], not char_height = char_bbox[3] - char_bbox[1] nor char_height = char_bbox[1] - char_bbox[3] which gives a negative number.

Source: https://github.com/python-pillow/Pillow/issues/7802

quark67 avatar Feb 19 '24 02:02 quark67