uuv_simulator icon indicating copy to clipboard operation
uuv_simulator copied to clipboard

auv_geometric_tracking_controller saturates fin angles instead of normalizing them

Open jzhu1234 opened this issue 5 years ago • 2 comments

In auv_geometric_tracking_controller.py, lines 284-287, I believe the code is supposed to normalize fin angles. However, it is doing the opposite and is increasing the fin angles.

Original: if max_angle >= self.max_fin_angle: fins = fins * max_angle / self.max_fin_angle -> fins * (some value greater than or equal to 1)

Correction: if max_angle >= self.max_fin_angle: fins = fins * self.max_fin_angle / max_angle -> fins * (Between 0 to 1)

jzhu1234 avatar Mar 04 '19 23:03 jzhu1234

Hi @jzhu1234, thanks for the report. I will have a look into this issue right away.

musamarcusso avatar Mar 13 '19 20:03 musamarcusso

@musamarcusso @jzhu1234 Could we close this issue?

pxalcantara avatar May 19 '20 20:05 pxalcantara