diffutils icon indicating copy to clipboard operation
diffutils copied to clipboard

Rename the `diffutils` binary to `diff`,

Open oSoMoN opened this issue 1 year ago • 4 comments

in preparation for the future implementation of other binaries (cmp, sdiff and diff3)

oSoMoN avatar Jun 04 '24 15:06 oSoMoN

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.06%. Comparing base (d362046) to head (9a7d8c8). Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
tests/integration.rs 0.00% 0 Missing and 16 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (d362046) and HEAD (9a7d8c8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (d362046) HEAD (9a7d8c8)
ubuntu_latest 2 1
macos_latest 2 0
windows_latest 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   82.48%   75.06%   -7.42%     
==========================================
  Files          10       10              
  Lines        2935     2876      -59     
  Branches      744      744              
==========================================
- Hits         2421     2159     -262     
  Misses        495      495              
- Partials       19      222     +203     
Flag Coverage Δ
macos_latest ?
ubuntu_latest 75.45% <0.00%> (ø)
windows_latest 15.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 15:06 codecov[bot]

what is your plan here? Create new binaries ?

What about doing the same as coreutils ? One main binaries (or individual programs) and if you do ln -s diffutils diff or ln -s diffutils cmp, it will change the behavior of the command.

sylvestre avatar Jun 04 '24 18:06 sylvestre

I was thinking of individual binaries, but I must admit I didn't look at how it's done for coreutils, and I suppose it makes sense to do something similar. I'll take a look later, in the meantime I'm leaving this PR open.

oSoMoN avatar Jun 04 '24 18:06 oSoMoN

the main adv is the size of the binaries as Rust bins have a tendency to be bigger than C :)

sylvestre avatar Jun 04 '24 18:06 sylvestre

Closing, as this is definitely being obsoleted by Gustavo's work in #88.

oSoMoN avatar Sep 26 '24 20:09 oSoMoN