coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

build-gnu.sh: Move {ch,run}con tests to Fedora VM and avoid wrong result

Open oech3 opened this issue 2 weeks ago • 5 comments

We can't build runcon and chcon without libselinux. But GNU no longer builds dummies of them. So move tests to Fedora VM: https://github.com/uutils/coreutils/actions/runs/20046833546/job/57494071620?pr=9607#step:15:34

Also some tests related with them were incorrectly passing due to false symlinks...

oech3 avatar Dec 08 '25 22:12 oech3

GNU testsuite comparison:

Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Note: The gnu test tests/runcon/runcon-compute is now being skipped but was previously passing.

github-actions[bot] avatar Dec 08 '25 22:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Note: The gnu test tests/runcon/runcon-compute is now being skipped but was previously passing.

github-actions[bot] avatar Dec 08 '25 23:12 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!

github-actions[bot] avatar Dec 09 '25 00:12 github-actions[bot]

Note that runcon-compute passes when runcon is false. This is not a regression. This should be commented.

oech3 avatar Dec 09 '25 00:12 oech3

GNU testsuite comparison:

GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/runcon/runcon-no-reorder is no longer failing!
Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

github-actions[bot] avatar Dec 19 '25 14:12 github-actions[bot]

@oech3 it caused a regression on GNU test failed: tests/runcon/runcon-compute. tests/runcon/runcon-compute is passing on 'main'. Maybe you have to rebase? could you please have a look? thanks

sylvestre avatar Dec 20 '25 10:12 sylvestre

runcon-compute was incorrectly passing by symlinking false binary to runcon.

oech3 avatar Dec 20 '25 10:12 oech3

So we should reset the result by someway. I don't know how to do that...

oech3 avatar Dec 20 '25 10:12 oech3