coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Fix hardware capabilities detection; cksum --debug

Open RenjiSann opened this issue 2 weeks ago • 5 comments

This MR fixes the GNU cksum.sh by correctly taking in account the GLIBC_TUNABLES env var

Fixes #9518

RenjiSann avatar Dec 08 '25 17:12 RenjiSann

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Dec 08 '25 17:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Dec 09 '25 09:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Dec 09 '25 09:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Dec 09 '25 11:12 github-actions[bot]

My string approach worked but was naive. Your enum-based design with TryFrom validation is the right way: type-safe, O(log n) lookups, feature alias support. Excellent work

            avx512: detect_avx512() && !disabled.contains(&"AVX512F".to_string()),
            avx2: detect_avx2() && !disabled.contains(&"AVX2".to_string()),
            pclmul: detect_pclmul() && !disabled.contains(&"PMULL".to_string()),
            vmull: detect_vmull() && !disabled.contains(&"VMULL".to_string()),
            sse2: detect_sse2() && !disabled.contains(&"SSE2".to_string()),
            asimd: detect_asimd() && !disabled.contains(&"ASIMD".to_string()),

naoNao89 avatar Dec 10 '25 06:12 naoNao89

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Dec 12 '25 14:12 github-actions[bot]

Congrats! The gnu test tests/cksum/cksum is no longer failing!

Kudos, good work!

cakebaker avatar Dec 12 '25 15:12 cakebaker